On 06/04/10 14:04, Markus Armbruster wrote: > Jes Sorensen <jes.soren...@redhat.com> writes: > >> On 06/04/10 10:15, Markus Armbruster wrote: >> What do you mean? The real ugh! here is that it was created as a >> typedef. I can change the function to pass in just the index, but I >> don't know if we will have cases where the rest is needed. > > Moving stuff out of the vl.c grabbag is cool. Moving stuff into the > sysemu.h grabbag is very uncool.
I agree, I have a new version of the patch coming up shortly. I just want to apply Paolo's idea of moving qemu-options.h around a bit. >>> Is this minor improvement of vl.c really worth the headaches elsewhere? >> >> vl.c as it is today is gross and un-maintainable. This patch gets rid of >> a lot of the ugly #ifdefs and makes the code easier to read and maintain. > > I'm not arguing against your patch, just trying to help making it even > better. I was gathering that, and your input is much appreciated. Cheers, Jes
