On Thu, Jan 14, 2016 at 05:22:39PM +0300, Denis V. Lunev wrote: > On 01/14/2016 05:18 PM, Marc-André Lureau wrote: > >Hi > > > >On Wed, Jan 6, 2016 at 1:01 PM, Denis V. Lunev <d...@openvz.org> wrote: > >>These patches add optional 'create' flag to guest-set-user-password command. > >>When it is specified, a new user will be created if it does not > >>exist yet. > >> > >What's the motivation to re-use set-password instead of a new command? > > because we will have to change the password later on after addition > of such user. Also this looks better for a case "create if not exists" and > force new password.
I don't think that's very compelling honestly. In addition when creating user accounts there's a whole bunch more parameters you potentially want to set besides just the username - see how many options exist with the 'useradd' command. Also with some users you might not want to set any password. So if we want to create users via QGA, I think that having a separate command makes more sense. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|