On 14 January 2016 at 15:21, Alex Bennée <[email protected]> wrote: > > Peter Maydell <[email protected]> writes: > >> Commit 8acc216b956 attempted to silence some sign-compare >> warnings in libvixl by adding -Wno-sign-compare to the CFLAGS >> for the relevant objects. Unfortunately it was ineffective >> because it was placed before $(QEMU_CFLAGS), so the -Wall in >> the general flags overrode -Wno-sign-compare rather than >> vice-versa. Reorder the flags so the warning suppression works. >> >> Thanks to Franz-Josef Haider <[email protected]> >> for pointing out what was wrong with the original patch. >> >> Signed-off-by: Peter Maydell <[email protected]> >> --- >> Alex, is there a way to test this patch against Travis before >> we commit it to master? > > Mea culpa: > > Reviewed-by: Alex Bennée <[email protected]> > > and a conditional: > > Tested-by: Alex Bennée <[email protected]> > > when: > > https://travis-ci.org/stsquad/qemu/builds/102371704
Test travis build completed OK, so I have pushed this fix to master. thanks -- PMM
