On Sat, Jan 23, 2016 at 09:39:57PM +0100, Hervé Poussineau wrote: > This patchset cleans up a little bit the Apple CUDA emulation: > - correctly reject unknown commands > - correctly reject commands with wrong parameters > - support changing the frequency of auto-polling > - support changing device list probed in auto-poll > - add logs when using FILE_SERVER_FLAG/SET_POWER_MESSAGE > - remove unused commands (GET/SET_6805_ADDR) > - remove unimplemented GET_SET_IIC/COMBINED_FORMAT_IIC > > GET_SET_IIC/COMBINED_FORMAT_IIC commands should be added again once > we implement the I2C bus provided by CUDA.
Overall, this doesn't seem to make any obvious functional difference in Mac OS 8/9 nor the Linux/BSD images I checked - but it's a clear improvement and it's also a much nicer baseline to build on! I can't think of any comments other than what has already been said. I wrote some code for the one-timer mode, and also added some more #defines instead of the magical constants. I guess I should refactor that on top of this patchset, though. You're going to look at the I2C code (I see that at least the EDID stuff uses it)? - Alyssa
