Dan Berrange rightly pointed out that now that commit 544a373 unboxes the variants of unions, we will need a way for his pending LUKS patches to access the fields of those variants without also allocating wasted memory.
Patch 1 is a cleanup I noticed along the way, although in writing this email, I now see it is only tangentially related. Patch 2 provides the fix Dan needs, and patch 3 documents it, along with other recent changes. Note that this series has a conflict with my other pending series (https://lists.gnu.org/archive/html/qemu-devel/2016-02/msg04703.html); but as it is shorter and is blocking Dan's patches, it may be easier to review these first. Depending on which series lands first, I don't mind posting a rebased version of the other series. Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-exportv1 and will soon be part of my branch at: http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi Eric Blake (3): qapi-dealloc: Reduce use outside of generated code qapi-visit: Expose visit_type_FOO_fields() qapi: Update docs to match recent generator changes scripts/qapi-visit.py | 47 ++----- hw/acpi/core.c | 11 +- net/net.c | 31 ++--- numa.c | 9 +- tests/test-opts-visitor.c | 10 +- docs/qapi-code-gen.txt | 308 ++++++++++++++++++++++++---------------------- 6 files changed, 188 insertions(+), 228 deletions(-) -- 2.5.0
