On 03/04/2016 07:40 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> Commit d0d7708b made ChardevDummy be an empty wrapper type around >> ChardevCommon. But there is no technical reason for this indirection, >> so simplify the code by directly using the base type. >> >> Also change the fallback assignment to assign u.null rather than >> u.data, since a future patch will remove the data member of the C >> struct generated for QAPI unions. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> >> Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > > Doesn't compile with MinGW: > > qemu/qemu-char.c: In function 'qemu_chr_open_win_con': > qemu/qemu-char.c:2186:29: warning: implicit declaration of function > 'qapi_ChardevDummy_base' [-Wimplicit-function-declaration] > ChardevCommon *common = qapi_ChardevDummy_base(backend->u.console); > ^
The curse of not compiling all the backends, and failing to grep for ChardevDummy. Replacement patch coming up soon. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
