On Tue, Mar 08, 2016 at 02:18:14PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imamm...@redhat.com>
> ---
> replaced link set check removed in previous patch
> ---
> hw/ppc/spapr.c | 26 ++++++++++++++++++++++----
> 1 file changed, 22 insertions(+), 4 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 6890a44..db33c29 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -2297,6 +2297,27 @@ void *spapr_populate_hotplug_cpu_dt(DeviceState *dev,
> CPUState *cs,
> return fdt;
> }
>
> +static void spapr_machine_device_pre_plug(HotplugHandler *hotplug_dev,
> + DeviceState *dev, Error **errp)
> +{
> + sPAPRMachineClass *smc = SPAPR_MACHINE_GET_CLASS(hotplug_dev);
> + sPAPRMachineState *spapr = SPAPR_MACHINE(hotplug_dev);
> +
> + if (object_dynamic_cast(OBJECT(dev), TYPE_SPAPR_CPU_CORE)) {
> + int core = object_property_get_int(OBJECT(dev), CPU_CORE_ID_PROP,
> + &error_abort);
> +
> + if (!smc->dr_cpu_enabled && dev->hotplugged) {
> + error_setg(errp, "CPU hotplug not supported for this machine");
> + return;
> + }
> + if (spapr->cores[core]) {
> + error_setg(errp, "core %d is already present", core);
> + return;
> + }
Wondering why can't we do the above check from core's realizefn and fail
the core hotplug from realizefn ?
Regards,
Bharata.
