On 03/10/2016 01:57 AM, Jitendra Kolhe wrote: >>> +++ b/qapi-schema.json >>> @@ -544,11 +544,14 @@ >>> # been migrated, pulling the remaining pages along as needed. >>> NOTE: If >>> # the migration fails during postcopy the VM will fail. (since >>> 2.5) >>> # >>> +# @skip-balloon: Skip scaning ram pages released by virtio-balloon driver. >> >> s/scaning/scanning/ >> >>> +# (since 2.5) >> >> You've missed 2.5. In fact, this is borderline between new feature and >> bug fix, so you may have even missed 2.6 since soft freeze has already >> passed, in which case this should read 2.7. > > Thanks for sharing the timeline was not aware of it. I think making changes > to > version 2.7 should be fine. However the version string "(since 2.5)" is > part of existing code. I have added a new option "skip-balloon" below it.
MigrationCapability is since 1.2, x-postcopy-ram is since 2.5, and your addition of skip-balloon is since 2.7. In other words, when you copy-pasted x-postcopy-ram's "(since 2.5)" as your starting point for writing the docs for your new skip-balloon, you need to update the version in which your new capability is actually exposed. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
