On 08.03.2016 05:44, Fam Zheng wrote: > Upon each bit toggle, the corresponding bit in the meta bitmap will be > set. > > Signed-off-by: Fam Zheng <f...@redhat.com> > Reviewed-by: John Snow <js...@redhat.com> > --- > block/dirty-bitmap.c | 2 +- > include/qemu/hbitmap.h | 17 +++++++++++++ > util/hbitmap.c | 66 > ++++++++++++++++++++++++++++++++++++++------------ > 3 files changed, 69 insertions(+), 16 deletions(-) > > diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c > index 16f73b2..0a188f2 100644 > --- a/block/dirty-bitmap.c > +++ b/block/dirty-bitmap.c > @@ -231,7 +231,7 @@ static void > bdrv_do_release_matching_dirty_bitmap(BlockDriverState *bs, > BdrvDirtyBitmap *bm, *next; > QLIST_FOREACH_SAFE(bm, &bs->dirty_bitmaps, list, next) { > if ((!bitmap || bm == bitmap) && (!only_named || bm->name)) { > - assert(!bitmap->active_iterators); > + assert(!bm->active_iterators);
I guess this should be squashed into patch 6. Good point, by the way, yes, using bitmap is wrong here. :-) Max
signature.asc
Description: OpenPGP digital signature