could you explain why we need this change ?

On 03/12/2016 04:39 PM, Pooja Dhannawat wrote:
Signed-off-by: Pooja Dhannawat <dhannawatpoo...@gmail.com>
---
  net/net.c | 8 ++++++--
  1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/net/net.c b/net/net.c
index b0c832e..5399758 100644
--- a/net/net.c
+++ b/net/net.c
@@ -709,16 +709,18 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const 
uint8_t *buf, int size)
  static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
                                 int iovcnt, unsigned flags)
  {
-    uint8_t buf[NET_BUFSIZE];
+    uint8_t *buf;
      uint8_t *buffer;
      size_t offset;

+    buf = g_new(uint8_t, 1);
+
      if (iovcnt == 1) {
          buffer = iov[0].iov_base;
          offset = iov[0].iov_len;
      } else {
          buffer = buf;
-        offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf));
+        offset = iov_to_buf(iov, iovcnt, 0, (uint8_t *)buf, sizeof(uint8_t));
      }

      if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
@@ -726,6 +728,8 @@ static ssize_t nc_sendv_compat(NetClientState *nc, const 
struct iovec *iov,
      } else {
forget to release 'buf'

          return nc->info->receive(nc, buffer, offset);
      }
+
+    g_free(buf);
  }

  ssize_t qemu_deliver_packet_iov(NetClientState *sender,


--
Best regards.
Li Zhijian



Reply via email to