On Fri, Mar 25, 2016 at 10:13:24AM +0800, Jason Wang wrote:
> We use the pointer to stack for key for new address space, this will break
> hash
> table searching, fixing by g_malloc() a new key instead.
>
> Cc: Michael S. Tsirkin <m...@redhat.com>
> Cc: Paolo Bonzini <pbonz...@redhat.com>
> Cc: Richard Henderson <r...@twiddle.net>
> Cc: Eduardo Habkost <ehabk...@redhat.com>
> Signed-off-by: Jason Wang <jasow...@redhat.com>
Acked-by: Peter Xu <pet...@redhat.com>
> ---
> hw/i386/intel_iommu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index d647b42..36b2072 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -1904,11 +1904,12 @@ VTDAddressSpace *vtd_find_add_as(IntelIOMMUState *s,
> PCIBus *bus, int devfn)
> char name[128];
>
> if (!vtd_bus) {
> + uintptr_t *new_key = g_malloc(sizeof(*new_key));
> + *new_key = (uintptr_t)bus;
> /* No corresponding free() */
> vtd_bus = g_malloc0(sizeof(VTDBus) + sizeof(VTDAddressSpace *) *
> VTD_PCI_DEVFN_MAX);
> vtd_bus->bus = bus;
> - key = (uintptr_t)bus;
> - g_hash_table_insert(s->vtd_as_by_busptr, &key, vtd_bus);
> + g_hash_table_insert(s->vtd_as_by_busptr, new_key, vtd_bus);
> }
>
> vtd_dev_as = vtd_bus->dev_as[devfn];
> --
> 2.5.0
>
