On Wed, Jun 16, 2010 at 10:20:36AM -0500, Anthony Liguori wrote: > On 06/16/2010 09:52 AM, Paolo Bonzini wrote: >> BTW it's obviously okay with signaling the condition when a threadlet is >> submitted. But when something affects all queue's workers >> (flush_threadlet_queue) you want a broadcast and using expiration as a >> substitute is fishy. > > IMHO, there shouldn't be a need for flush_threadlet_queue. It doesn't look > used in the aio conversion and if virtio-9p needs it, I suspect something > is wrong.
virtio-9p doesn't need it. The API has been added for the vnc-server case, where a subsystem wants to wait on the threads of it's private queue to finish executing the already queued tasks. It's the responsibility of the subsystem to make sure that new tasks are not submitted during this interval. I sought clarification regarding this earlier, http://lists.gnu.org/archive/html/qemu-devel/2010-06/msg01382.html But now I am beginning to doubt I understood the use-case correctly. > > Regards, > > Anthony Liguori -- Thanks and Regards gautham
