> Commiserations on the first failed-to-build pullreq of the 2.7 cycle: > > /home/pm215/qemu/ui/gtk.c: In function ‘gd_menu_copy’: > /home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable ‘vc’ > [-Werror=unused-variable] > VirtualConsole *vc = gd_vc_find_current(s); > ^ > > This was on ppc64be Linux, though I'm guessing that's just because > it's the only system that happens not to define CONFIG_VTE.
mingw builds don't have vte too, so I'm wondering now how that one managed to escape my attention ... > (Q: should we even put the "Copy" entry into the menu if we can't > actually support copying text ?) I was trying to not clutter up the patch with too many #ifdef CONFIG_VTE. But, yes, probably we should just #ifdef the whole function and and not add the menu entry. cheers, Gerd
