On 02/29/2016 05:00 AM, Daniel P. Berrange wrote: > Now that qcow & qcow2 are wired up to get encryption keys > via the QCryptoSecret object, nothing is relying on the > interactive prompting for passwords. All the code related > to password prompting can thus be ripped out. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > hmp.c | 31 --------------------- > hw/usb/dev-storage.c | 34 ------------------------ > include/monitor/monitor.h | 7 ----- > include/qemu/osdep.h | 2 -- > monitor.c | 68 > ----------------------------------------------- > qemu-img.c | 31 --------------------- > qemu-io.c | 21 --------------- > qmp.c | 10 +------ > tests/qemu-iotests/087 | 2 ++ > util/oslib-posix.c | 66 --------------------------------------------- > util/oslib-win32.c | 24 ----------------- > 11 files changed, 3 insertions(+), 293 deletions(-)
Missed a spot: in qapi-schema.json, human-monitor-command states: # Notes: This command only exists as a stop-gap. Its use is highly # discouraged. The semantics of this command are not guaranteed. ... # o Commands that prompt the user for data (eg. 'cont' when the block # device is encrypted) don't currently work but after your series, cont no longer prompts for passwords so the comment is (or will be) stale and worth removing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
