On Wed, May 18, 2016 at 10:09:27AM +0200, Igor Mammedov wrote: > On Tue, 17 May 2016 09:29:15 -0600 > Eric Blake <ebl...@redhat.com> wrote: > > > On 05/17/2016 08:43 AM, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > > > --- > > > hw/acpi/cpu.c | 83 > > > +++++++++++++++++++++++++++++++++++++++++++++++++++ > > > hw/acpi/ich9.c | 3 ++ > > > hw/acpi/piix4.c | 3 ++ > > > include/hw/acpi/cpu.h | 4 +++ > > > qapi-schema.json | 3 +- > > > trace-events | 2 ++ > > > 6 files changed, 97 insertions(+), 1 deletion(-) > > > > > > > > +++ b/qapi-schema.json > > > @@ -4018,8 +4018,9 @@ > > > ## @ACPISlotType > > > # > > > # @DIMM: memory slot > > > +# @CPU: logical CPU slot > > > > Missing a marker '(since 2.7)' > thanks, fixed in v2.
v2 was never posted. > > > # > > > -{ 'enum': 'ACPISlotType', 'data': [ 'DIMM' ] } > > > +{ 'enum': 'ACPISlotType', 'data': [ 'DIMM', 'CPU' ] } > > > > Hmm. ACPISlotType is already on our whitelist of exceptions that allow > > upper-case names (we prefer lower), so adding another one doesn't > > necessarily hurt. > I'll keep that in mind. >