On 05/31/2016 10:35 AM, Laurent Vivier wrote: > Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d). > > This patch is the result of coccinelle script > scripts/coccinelle/round.cocci > > CC: qemu-bl...@nongnu.org > Signed-off-by: Laurent Vivier <lviv...@redhat.com> > --- > block/vvfat.c | 3 +-- > hw/block/tc58128.c | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/block/vvfat.c b/block/vvfat.c > index a39dbe6..6d2e21c 100644 > --- a/block/vvfat.c > +++ b/block/vvfat.c > @@ -1960,8 +1960,7 @@ DLOG(fprintf(stderr, "check direntry %d:\n", i); > print_direntry(direntries + i)) > /* check file size with FAT */ > cluster_count = get_cluster_count_for_direntry(s, direntries + > i, path2); > if (cluster_count != > - (le32_to_cpu(direntries[i].size) + s->cluster_size > - - 1) / s->cluster_size) { > + DIV_ROUND_UP(le32_to_cpu(direntries[i].size), s->cluster_size)) {
The tab-vs.-space issues in this file make the patch look weird. It's not your fault, but you may want to manually touch up the result so that visual indentation under 8-spaces-per-tab still looks okay. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature