* Stefano Stabellini (sstabell...@kernel.org) wrote: > On Thu, 2 Jun 2016, Stefano Stabellini wrote: > > On Wed, 1 Jun 2016, Dr. David Alan Gilbert wrote: > > > * Amit Shah (amit.s...@redhat.com) wrote: > > > > Dave, can you take a look? > > > > > > Yes, I think I'm happy with it; > > > > > > Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > > > > > I think people might try interesting non-Xen things with it; for > > > example I think if you backed QEMU's main RAM by a /tmp file > > > perhaps you could start a guest up even under KVM just > > > by loading the devices. > > > > I added this patch to the Xen queue. > > I spoke too quickly. I get: > > /local/qemu/migration/savevm.c: In function 'qmp_xen_load_devices_state': > /local/qemu/migration/savevm.c:2089:5: error: implicit declaration of > function 'qemu_fopen' [-Werror=implicit-function-declaration] > /local/qemu/migration/savevm.c:2089:5: error: nested extern declaration of > 'qemu_fopen' [-Werror=nested-externs] > /local/qemu/migration/savevm.c:2089:7: error: assignment makes pointer from > integer without a cast [-Werror]
Ah, yes, your problem is that Dan's crypto changes have probably just removed that; see qmp_xen_save_devices_state and 8925839f that changed it to use the new qio_channel_file_new_path. Dave > CC i386-softmmu/hw/display/virtio-vga.o > cc1: all warnings being treated as errors -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
