Le 02/06/2016 à 17:39, Peter Maydell a écrit : > On 2 June 2016 at 16:34, Laurent Vivier <laur...@vivier.eu> wrote: >> Le 24/05/2016 à 14:54, Riku Voipio a écrit : >>> dropped since the build failed on squeeze. I take the simplest fix is to >>> wrap all nl support #ifdef IFLA_PROTO_DOWN since that is the newest >>> define available. > >> What do you think if instead I add a "--disable-netlink" (enabled by >> default) in configure? > > I don't think we need a command line switch for this -- we should only > have those for cases where there's a reasonable user decision to > say "I don't want feature X (even if my host might support it)". > For this kind of thing we should just have a configure test for > "do the host headers support feature X" and unconditionally use it > if present. That's what we do for things like CONFIG_FIEMAP, for instance.
ok, but in this case what is the best solution: 1- to check the host environment in configure and define (or not) a CONFIG_NETLINK, 2- Add a "#ifdef IFLA_PROTO_DOWN" directly in the code? Thanks, Laurent
