On Fri, Jun 10, 2016 at 07:40:11PM +0200, Andrew Jones wrote: > This series is a first step in eliminating smp_* global > variables (the last patch gets rid of two of them!) And, it's > a first step in deprecating '-smp' in favor of using machine > properties, e.g. > qemu -machine pc,sockets=2,cores=2,threads=2,maxcpus=8,cpus=8 ... > > It's also a first step in allowing machine types to override > the default parameter parsing, which makes assumptions that > not all machine types may agree with. (mach-virt is coming...) > > So, three first steps, I guess that's 3 steps. And a forth > thing it does is some fixes for the smp parsing and also for > SMBIOS use of cpu topology. > > Tested with kvm-unit-tests on all five arches supported > there, x86_64 both with KVM and TCG, and booting an x86_64 > guest (KVM) to check SMBIOS before and after in order to make > sure it was the same. Also compile tested all targets.
I forgot to run 'make check'. Just did now. All but one test passed. Nope, it wasn't pc-cpu-test (the only cpu topology using test) that failed. That one did output two new warnings, so I should fix and/or deprecate it. The one that did fail was vhost-user-test. I confirmed that it does not fail without this series. I'll look into it soon, maybe tomorrow. drew
