On 30/06/2016 14:53, Markus Armbruster wrote: > +bad-header-comment := /* FIXME Does not pass make > check-headers$(bad-header-with-y), yet! > +bad-headers := $(shell cd $(SRC_PATH) && fgrep -l '$(bad-header-comment)' > $(src-headers)) > +bad-headers += $(shell fgrep -l '$(bad-header-comment)' $(gen-headers)) > +# Headers that require -DNEED_CPU_H etc. > +target-header-comment := /* NOTE: May only be included into target-dependent > code */
Perhaps accept a "FIXME" as well here? You don't have to use the right one in the patch of course. > diff --git a/target-sparc/cpu-qom.h b/target-sparc/cpu-qom.h > index f63af72..30d112c 100644 > --- a/target-sparc/cpu-qom.h > +++ b/target-sparc/cpu-qom.h > @@ -17,6 +17,9 @@ > * License along with this library; if not, see > * <http://www.gnu.org/licenses/lgpl-2.1.html> > */ > + > +/* NOTE: May only be included into target-dependent code */ This shouldn't be true for cpu-qom.h. Perhaps Paolo > #ifndef QEMU_SPARC_CPU_QOM_H > #define QEMU_SPARC_CPU_QOM_H >
