On 06/29/2016 09:55 AM, Markus Armbruster wrote: > Tracked down with an ugly, brittle and probably buggy Perl script. > > Also move includes converted to <...> up so they get included before > ours where that's obviously okay. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > ---
> +++ b/qga/vss-win32/provider.cpp > @@ -12,8 +12,8 @@ > > #include "qemu/osdep.h" > #include "vss-common.h" > -#include "inc/win2003/vscoordint.h" > -#include "inc/win2003/vsprov.h" > +#include <inc/win2003/vscoordint.h> > +#include <inc/win2003/vsprov.h> Worth hoisting <> before "" in this file? > > #define VSS_TIMEOUT_MSEC (60*1000) > > diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp > index 889052d..0cd2f0e 100644 > --- a/qga/vss-win32/requester.cpp > +++ b/qga/vss-win32/requester.cpp > @@ -13,8 +13,8 @@ > #include "qemu/osdep.h" > #include "vss-common.h" > #include "requester.h" > -#include "inc/win2003/vswriter.h" > -#include "inc/win2003/vsbackup.h" > +#include <inc/win2003/vswriter.h> > +#include <inc/win2003/vsbackup.h> Ditto. > +++ b/tests/tcg/xtensa/linker.ld.S > @@ -1,4 +1,4 @@ > -#include <core-isa.h> > +#include "core-isa.h" > Just making sure that "" vs. <> isn't going to hurt assembler files, since the rules on preprocessing those may be different. Reviewed-by: Eric Blake <ebl...@redhat.com> Tested-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature