On Wed, Jul 06, 2016 at 08:20:40AM +0200, Igor Mammedov wrote: [...] > +static void pc_cpu_pre_plug(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + int idx; > + X86CPU *cpu = X86_CPU(dev); > + PCMachineState *pcms = PC_MACHINE(hotplug_dev); > + CPUArchId *cpu_slot = pc_find_cpu_slot(pcms, CPU(dev), &idx);
Why are you passing &idx to pc_find_cpu_slot() here, if you don't use it for anything? -- Eduardo