On Wed, Jul 13, 2016 at 10:26:13AM +0800, Cao jin wrote: > -void aio_context_setup(AioContext *ctx, Error **errp) > +void aio_context_setup(AioContext *ctx) > { > #ifdef CONFIG_EPOLL_CREATE1 > assert(!ctx->epollfd); > ctx->epollfd = epoll_create1(EPOLL_CLOEXEC); > if (ctx->epollfd == -1) { > + fprintf(stderr, "Failed to create epoll instance");
Please include errno so it's clear whether this happened due to EMFILE, ENOMEM, ENOSYS, etc. > diff --git a/include/block/aio.h b/include/block/aio.h > index 88a64ee..0922b69 100644 > --- a/include/block/aio.h > +++ b/include/block/aio.h > @@ -439,6 +439,6 @@ static inline bool aio_node_check(AioContext *ctx, bool > is_external) > * > * Initialize the aio context. > */ > -void aio_context_setup(AioContext *ctx, Error **errp); > +void aio_context_setup(AioContext *ctx); This function is also implemented in aio-win32.c so this patch breaks the build.
signature.asc
Description: PGP signature