On 15/07/2016 12:10, Peter Lieven wrote: > Am 15.07.2016 um 12:07 schrieb Gerd Hoffmann: >> On Fr, 2016-07-15 at 11:45 +0200, Peter Lieven wrote: >>> commit 095497ff added thread local storage for the color counting >>> palette. Unfortunately, a VncPalette is about 7kB on a x86_64 system. >>> This memory is reserved from the stack of every thread and it >>> exhausted the stack space of a libxenstore thread. >>> >>> Fix this by allocating memory only for the VNC encoding thread. >> Added to vnc queue. > > Please wait. Paolo mentioned that TLS is not allocated from the stack.
Actually it does---which is not a problem, but then the stack size from pthread attributes should be increased IMHO. Anyway, the patch is okay. Paolo > Maybe this patch is ok, but we need a different commit message then.