On 07/29/16 09:29, Markus Armbruster wrote:
> Missed when commit 5712db6 split off "fw_cfg_io" and "fw_cfg_mem".
>
> Signed-off-by: Markus Armbruster <arm...@redhat.com>
> ---
> hw/nvram/fw_cfg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 2873030..0ccab2d 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -990,6 +990,7 @@ static void fw_cfg_class_init(ObjectClass *klass, void
> *data)
> static const TypeInfo fw_cfg_info = {
> .name = TYPE_FW_CFG,
> .parent = TYPE_SYS_BUS_DEVICE,
> + .abstract = true,
> .instance_size = sizeof(FWCfgState),
> .class_init = fw_cfg_class_init,
> };
>
Not sure how consistent we try to be about this: should the equal sign
(in the assignment) line up with the other equal signs?
Looking for prior art, I ran
git grep -E 'abstract {2,}= true'
and it returned 27 hits.
Functionally the patch is right, of course. And I think the whitespace
can be adjusted without a repost, if we agree it should be adjusted.
Reviewed-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
Laszlo
