> I'd prefer if Paolo's remark (about blk_drain()'s ability to produce > more failed requests, stashed in s->rq) were captured in either the > commit message, or in a code comment. Something like: > > /* We drop queued requests after blk_drain() because blk_drain() > * itself can produce them. */
It's also (perhaps especially) because blk_drain() can consume them. Fam's patch to do blk_drain() first would cause a double-free. Paolo > What do you think? It's your call. I certainly lacked that bit of > information. > > Reviewed-by: Laszlo Ersek <ler...@redhat.com> > > Thanks! > Laszlo >
