On 11.08.2016 13:32, David Kiarie wrote:
On Thu, Aug 11, 2016 at 11:23 AM, Valentine Sinitsyn
<valentine.sinit...@gmail.com <mailto:valentine.sinit...@gmail.com>> wrote:
Hi,
On 02.08.2016 13:39, David Kiarie wrote:
+static void amdvi_writeq_raw(AMDVIState *s, uint64_t val,
hwaddr addr)
+{+
+static void amdvi_generate_msi_interrupt(AMDVIState *s)
+{
+ MSIMessage msg;
+ if (msi_enabled(&s->pci.dev)) {
+ msg = msi_get_message(&s->pci.dev, 0);
+ address_space_stl_le(&address_space_memory,
msg.address, msg.data,
+ MEMTXATTRS_UNSPECIFIED, NULL);
Nit: don't you want to set the requester ID to the IOMMU's BDF here?
We could though I overlooked that because IOMMU interrupt requests are
not processed by IOMMU.
True, that's the prefix. It's a matter of cleanness, not a bug, so you
choose. Can be changed any time later in the tree.
Valentine
