On 02/09/2016 20:10, Eduardo Habkost wrote: > On Fri, Sep 02, 2016 at 04:56:49PM +0200, Paolo Bonzini wrote: >> On 02/09/2016 16:04, Eduardo Habkost wrote: > [...] >>> Now, why exactly vhost-user-test needs accel=tcg and can't use >>> accel=qtest? >> >> Because it uses iPXE to exercise the NIC. > > Is it used to actually exercise the NIC, or just to initialize > it?
Well that's one way to exercise it. :) > Original commit says "pc-bios/pxe-virtio.rom is used to > instantiate a virtio pcicontroller". I don't see any test code > that receives any data from iPXE: nothing is read from log_fd, > the VHOST_USER_SET_VRING_KICK/VHOST_USER_SET_VRING_CALL FDs are > simply ignored. The only memory writes/reads are on the first > memory page. > > I suggest simply using libqos. If somebody really wants rx/tx > tests using vhost-user, they can be written using libqos (just > like virtio-net-test.c). Ok, this makes sense. Paolo