On 09/08/2016 01:06 PM, Peter Maydell wrote: >> +++ b/tests/tcg/cris/sys.h >> @@ -3,6 +3,8 @@ >> #define STRINGIFY(x) #x >> #define TOSTRING(x) STRINGIFY(x) >> >> +#define inline inline __attribute__((always_inline)) >> + > > I think redefining C keywords is generally a bad idea. > Can you instead define an "always_inline" macro and > use it where necessary?
In fact, commit b11d029b is an instance where compilation failed weirdly because we redefined inline. I agree that a separate macro name, added on where desired, rather than redefining 'inline' itself, is desirable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature