Benjamin Herrenschmidt <b...@kernel.crashing.org> writes: > On Fri, 2016-09-09 at 16:15 +0530, Nikunj A Dadhania wrote: >> >> + env->tlb_need_flush = TLB_NEED_GLOBAL_FLUSH | TLB_NEED_LOCAL_FLUSH; >> check_tlb_flush(env th, 1); >> > > Hrm... how did that work bore ? IE. check_tlb_flush won't do anything > if tlb_need_flush is 0, isn't it already set elsewhere ?
Error of my judgement, it is set in remove_hpte, so the above condition is not required. Good catch. Regards Nikunj