Hello Dmitry,
+-- On Tue, 13 Sep 2016, Dmitry Fleytman wrote --+
| It should be in the same patch because otherwise a broken logic will be
| introduced.
Not even same patch-set?
| pvscsi_build_sglist() must perform all rollback actions required to handle
| the error cleanly. Please also note that pvscsi_build_sglist() caller(s)
| should be aware of SG list creation failure and handle this error scenario
| accordingly.
I see. All callers leading up to 'pvscsi_convert_sglist' appear to be
returning void.
MemoryRegionOps pvscsi_ops = {
.write = pvscsi_io_write
-> pvscsi_io_write
-> pvscsi_process_io
->pvscsi_process_request_descriptor
-> pvscsi_build_sglist
-> pvscsi_convert_sglist
This looks to be a big patch to fix an infinite loop issue. It'll help to
separate the two patches, no?
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
