Hi, Your series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 1474063242-27419-1-git-send-email-...@twiddle.net Subject: [Qemu-devel] [PATCH v18 00/13] AVR target === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 58f0bcb target-avr: Merge translate-inst.inc.c into translate.c f0b4956 target-avr: Respect .inc.c convention 390da65 target-avr: Put all translation code into one compilation unit 93e0b30 target-avr: Put env pointer in DisasContext 8862669 target-avr: adding instruction decoder 1b8ab42 target-avr: instruction decoder generator a243c5a target-avr: adding instruction translation 72ba9fc target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions f85d68f target-avr: adding AVR interrupt handling 7a9f664 target-avr: adding instructions encodings b7a16a1 target-avr: adding a sample AVR board 140ca0e target-avr: adding AVR CPU features/flavors 7049535 target-avr: AVR cores support is added. === OUTPUT BEGIN === Checking PATCH 1/13: target-avr: AVR cores support is added.... Checking PATCH 2/13: target-avr: adding AVR CPU features/flavors... Checking PATCH 3/13: target-avr: adding a sample AVR board... Checking PATCH 4/13: target-avr: adding instructions encodings... Checking PATCH 5/13: target-avr: adding AVR interrupt handling... Checking PATCH 6/13: target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions... Checking PATCH 7/13: target-avr: adding instruction translation... Checking PATCH 8/13: target-avr: instruction decoder generator... ERROR: suspect code indent for conditional statements (4, 4) #810: FILE: target-avr/cpugen/src/cpugen.cpp:440: + if (argc != 2) { [...] + } total: 1 errors, 0 warnings, 1220 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/13: target-avr: adding instruction decoder... Checking PATCH 10/13: target-avr: Put env pointer in DisasContext... ERROR: "foo* bar" should be "foo *bar" #1119: FILE: target-avr/translate-inst.h:26: +int avr_translate_NOP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1122: FILE: target-avr/translate-inst.h:28: +int avr_translate_MOVW(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1131: FILE: target-avr/translate-inst.h:39: +int avr_translate_MULS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1140: FILE: target-avr/translate-inst.h:50: +int avr_translate_MULSU(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1149: FILE: target-avr/translate-inst.h:61: +int avr_translate_FMUL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1158: FILE: target-avr/translate-inst.h:72: +int avr_translate_FMULS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1167: FILE: target-avr/translate-inst.h:83: +int avr_translate_FMULSU(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1176: FILE: target-avr/translate-inst.h:94: +int avr_translate_CPC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1185: FILE: target-avr/translate-inst.h:106: +int avr_translate_SBC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1194: FILE: target-avr/translate-inst.h:118: +int avr_translate_ADD(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1203: FILE: target-avr/translate-inst.h:130: +int avr_translate_AND(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1212: FILE: target-avr/translate-inst.h:142: +int avr_translate_EOR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1221: FILE: target-avr/translate-inst.h:154: +int avr_translate_OR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1230: FILE: target-avr/translate-inst.h:166: +int avr_translate_MOV(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1239: FILE: target-avr/translate-inst.h:178: +int avr_translate_CPSE(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1248: FILE: target-avr/translate-inst.h:190: +int avr_translate_CP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1257: FILE: target-avr/translate-inst.h:202: +int avr_translate_SUB(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1266: FILE: target-avr/translate-inst.h:214: +int avr_translate_ADC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1275: FILE: target-avr/translate-inst.h:226: +int avr_translate_CPI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1284: FILE: target-avr/translate-inst.h:238: +int avr_translate_SBCI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1293: FILE: target-avr/translate-inst.h:250: +int avr_translate_ORI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1302: FILE: target-avr/translate-inst.h:262: +int avr_translate_SUBI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1311: FILE: target-avr/translate-inst.h:274: +int avr_translate_ANDI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1320: FILE: target-avr/translate-inst.h:286: +int avr_translate_LDDZ(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1329: FILE: target-avr/translate-inst.h:299: +int avr_translate_LDDY(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1338: FILE: target-avr/translate-inst.h:312: +int avr_translate_STDZ(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1347: FILE: target-avr/translate-inst.h:325: +int avr_translate_STDY(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1356: FILE: target-avr/translate-inst.h:338: +int avr_translate_LDS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1365: FILE: target-avr/translate-inst.h:349: +int avr_translate_LDZ2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1372: FILE: target-avr/translate-inst.h:355: +int avr_translate_LDZ3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1379: FILE: target-avr/translate-inst.h:361: +int avr_translate_LPM2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1386: FILE: target-avr/translate-inst.h:367: +int avr_translate_LPMX(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1393: FILE: target-avr/translate-inst.h:373: +int avr_translate_ELPM2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1400: FILE: target-avr/translate-inst.h:379: +int avr_translate_ELPMX(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1407: FILE: target-avr/translate-inst.h:385: +int avr_translate_LDY2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1414: FILE: target-avr/translate-inst.h:391: +int avr_translate_LDY3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1421: FILE: target-avr/translate-inst.h:397: +int avr_translate_LDX1(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1428: FILE: target-avr/translate-inst.h:403: +int avr_translate_LDX2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1435: FILE: target-avr/translate-inst.h:409: +int avr_translate_LDX3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1442: FILE: target-avr/translate-inst.h:415: +int avr_translate_POP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1449: FILE: target-avr/translate-inst.h:421: +int avr_translate_STS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1458: FILE: target-avr/translate-inst.h:432: +int avr_translate_STZ2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1465: FILE: target-avr/translate-inst.h:438: +int avr_translate_STZ3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1472: FILE: target-avr/translate-inst.h:444: +int avr_translate_XCH(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1479: FILE: target-avr/translate-inst.h:450: +int avr_translate_LAS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1486: FILE: target-avr/translate-inst.h:456: +int avr_translate_LAC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1493: FILE: target-avr/translate-inst.h:462: +int avr_translate_LAT(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1500: FILE: target-avr/translate-inst.h:468: +int avr_translate_STY2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1507: FILE: target-avr/translate-inst.h:474: +int avr_translate_STY3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1514: FILE: target-avr/translate-inst.h:480: +int avr_translate_STX1(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1521: FILE: target-avr/translate-inst.h:486: +int avr_translate_STX2(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1528: FILE: target-avr/translate-inst.h:492: +int avr_translate_STX3(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1535: FILE: target-avr/translate-inst.h:498: +int avr_translate_PUSH(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1542: FILE: target-avr/translate-inst.h:504: +int avr_translate_COM(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1549: FILE: target-avr/translate-inst.h:510: +int avr_translate_NEG(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1556: FILE: target-avr/translate-inst.h:516: +int avr_translate_SWAP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1563: FILE: target-avr/translate-inst.h:522: +int avr_translate_INC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1570: FILE: target-avr/translate-inst.h:528: +int avr_translate_ASR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1577: FILE: target-avr/translate-inst.h:534: +int avr_translate_LSR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1584: FILE: target-avr/translate-inst.h:540: +int avr_translate_ROR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1591: FILE: target-avr/translate-inst.h:546: +int avr_translate_BSET(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1598: FILE: target-avr/translate-inst.h:552: +int avr_translate_IJMP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1601: FILE: target-avr/translate-inst.h:554: +int avr_translate_EIJMP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1604: FILE: target-avr/translate-inst.h:556: +int avr_translate_BCLR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1611: FILE: target-avr/translate-inst.h:562: +int avr_translate_RET(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1614: FILE: target-avr/translate-inst.h:564: +int avr_translate_RETI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1617: FILE: target-avr/translate-inst.h:566: +int avr_translate_ICALL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1620: FILE: target-avr/translate-inst.h:568: +int avr_translate_EICALL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1623: FILE: target-avr/translate-inst.h:570: +int avr_translate_SLEEP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1626: FILE: target-avr/translate-inst.h:572: +int avr_translate_BREAK(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1629: FILE: target-avr/translate-inst.h:574: +int avr_translate_WDR(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1632: FILE: target-avr/translate-inst.h:576: +int avr_translate_LPM1(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1635: FILE: target-avr/translate-inst.h:578: +int avr_translate_ELPM1(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1638: FILE: target-avr/translate-inst.h:580: +int avr_translate_SPM(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1641: FILE: target-avr/translate-inst.h:582: +int avr_translate_SPMX(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1644: FILE: target-avr/translate-inst.h:584: +int avr_translate_DEC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1651: FILE: target-avr/translate-inst.h:590: +int avr_translate_DES(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1658: FILE: target-avr/translate-inst.h:596: +int avr_translate_JMP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1666: FILE: target-avr/translate-inst.h:603: +int avr_translate_CALL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1674: FILE: target-avr/translate-inst.h:610: +int avr_translate_ADIW(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1683: FILE: target-avr/translate-inst.h:622: +int avr_translate_SBIW(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1692: FILE: target-avr/translate-inst.h:634: +int avr_translate_CBI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1701: FILE: target-avr/translate-inst.h:645: +int avr_translate_SBIC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1710: FILE: target-avr/translate-inst.h:656: +int avr_translate_SBI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1719: FILE: target-avr/translate-inst.h:667: +int avr_translate_SBIS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1728: FILE: target-avr/translate-inst.h:678: +int avr_translate_MUL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1737: FILE: target-avr/translate-inst.h:690: +int avr_translate_IN(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1746: FILE: target-avr/translate-inst.h:702: +int avr_translate_OUT(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1755: FILE: target-avr/translate-inst.h:714: +int avr_translate_RJMP(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1762: FILE: target-avr/translate-inst.h:720: +int avr_translate_LDI(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1771: FILE: target-avr/translate-inst.h:732: +int avr_translate_RCALL(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1778: FILE: target-avr/translate-inst.h:738: +int avr_translate_BRBS(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1787: FILE: target-avr/translate-inst.h:749: +int avr_translate_BRBC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1796: FILE: target-avr/translate-inst.h:760: +int avr_translate_BLD(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1805: FILE: target-avr/translate-inst.h:771: +int avr_translate_BST(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1814: FILE: target-avr/translate-inst.h:782: +int avr_translate_SBRC(DisasContext* ctx, uint32_t opcode); ERROR: "foo* bar" should be "foo *bar" #1823: FILE: target-avr/translate-inst.h:793: +int avr_translate_SBRS(DisasContext* ctx, uint32_t opcode); total: 97 errors, 0 warnings, 1743 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 11/13: target-avr: Put all translation code into one compilation unit... ERROR: externs should be avoided in .c files #1615: FILE: target-avr/translate.c:64: +uint32_t get_opcode(uint8_t const *code, unsigned bitBase, unsigned bitSize); total: 1 errors, 0 warnings, 1493 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 12/13: target-avr: Respect .inc.c convention... Checking PATCH 13/13: target-avr: Merge translate-inst.inc.c into translate.c... === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org