Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [Bug 1625216] [NEW] memory writes via gdb don't work for 
memory mapped hardware
Message-id: 20160919143701.1959.82839.malone...@soybean.canonical.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
f1cd6ef memory writes via gdb don't work for memory mapped hardware

=== OUTPUT BEGIN ===
Checking PATCH 1/1: memory writes via gdb don't work for memory mapped 
hardware...
ERROR: trailing whitespace
#50: FILE: exec.c:3622:
+            /* if ram/rom region we access the memory $

ERROR: line over 90 characters
#54: FILE: exec.c:3626:
+            MemoryRegion *mr = address_space_translate(as, phys_addr, &addr1, 
&mr_len, is_write);

WARNING: line over 80 characters
#55: FILE: exec.c:3627:
+            is_memcpy_access  = memory_region_is_ram(mr) || 
memory_region_is_romd(mr);

ERROR: space required before the open parenthesis '('
#56: FILE: exec.c:3628:
+            if(mr_len < len) {

ERROR: trailing whitespace
#57: FILE: exec.c:3629:
+                /* TODO, mimic more of the loop over mr chunks as $

ERROR: trailing whitespace
#58: FILE: exec.c:3630:
+                   done in cpu_physical_memory_write_internal */ $

ERROR: else should follow close brace '}'
#63: FILE: exec.c:3635:
+        }
+        else {

ERROR: trailing whitespace
#66: FILE: exec.c:3638:
+        $

ERROR: Missing Signed-off-by: line(s)

total: 8 errors, 1 warnings, 40 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org

Reply via email to