On 20/09/2016 16:59, Alex Bennée wrote:
> > Looks fine to me, would be nicer to have an idea of the performance hit,
> > but I suppose it is marginal.
> I was surprised that CONFIG_QOM_CAST_DEBUG is the default because it
> does a bunch of stuff on every cast. The other option of course would be
> to use --disable-qom-cast-debug when building for sanitizers although
> maybe we should just be defaulting to off?
The casts are not too expensive and usually are not in the fast paths
(we use explicit C casts there) so we were leaving them enabled. They
do find bugs sometimes.