On 09/20/2016 06:38 AM, Kevin Wolf wrote: > In order to remove the necessity to use BlockBackend names in the
What you have works, but still feels a bit awkward to this native speaker. You could get away with the shorter: In order to remove the need for BlockBackend names... Up to you if you want to tweak the series (many commits share this pattern). > external API, we want to allow qdev device names in all device related > commands. > > This converts blockdev-open/close-tray to accept a qdev device name. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > blockdev.c | 61 > ++++++++++++++++++++++++++++++++++++++------------- > docs/qmp-commands.txt | 12 ++++++---- > qapi/block-core.json | 14 ++++++++---- > 3 files changed, 64 insertions(+), 23 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
