On Mon, Aug 15, 2016 at 10:11:53AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2016-08-15 at 09:59 +1000, Benjamin Herrenschmidt wrote: > > Bla bla bla bla ... > > > > Seriously, we have nazi stylebot on the list now ? > > > > I made conscious decisions to style it this way and as far as the tabs > > in the .h are concerned, that's because the file is lifted from Linux > > and I'd like to keep it intact as much as possible. > > There are actually a couple of places where I agree with the style > change, so I'll include that in a futher post after more useful review > has been posted (seriously, stylebots are just infuriating).
So.. as irritating as you find the bot, there are a bunch of gratuitous style problems. In particular sungem.c itself isn't consistent about whether it has 8 char or 4 char indentation. That really does need to be fixed. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Description: PGP signature