> From: Felipe Franciosi [mailto:fel...@nutanix.com] > If compiling with -Werror=unused-result, replay-internal.c won't build > due to a call to fwrite() where the returned value is ignored. A simple > cast to (void) is not sufficient on recent GCCs, so this fixes it. > > Signed-off-by: Felipe Franciosi <fel...@nutanix.com> > --- > replay/replay-internal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/replay/replay-internal.c b/replay/replay-internal.c > index 5835e8d..6978d76 100644 > --- a/replay/replay-internal.c > +++ b/replay/replay-internal.c > @@ -65,7 +65,7 @@ void replay_put_array(const uint8_t *buf, size_t size) > { > if (replay_file) { > replay_put_dword(size); > - fwrite(buf, 1, size, replay_file); > + (void)(fwrite(buf, 1, size, replay_file)+1); > } > }
This looks very weird. I think it would be better to check the return value and stop the simulation in case of error. Pavel Dovgalyuk
