On Mon, Sep 19, 2016 at 11:59:32AM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt <b...@kernel.crashing.org> > > This will make life easier for dealing with dynamically configured > ICSes such as PHB3 > > Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > Signed-off-by: Nikunj A Dadhania <nik...@linux.vnet.ibm.com>
This seems reasonable on its own, so I've applied it to ppc-for-2.8. > --- > include/hw/ppc/xics.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h > index 1ea40bd..e49a2da 100644 > --- a/include/hw/ppc/xics.h > +++ b/include/hw/ppc/xics.h > @@ -151,7 +151,7 @@ struct ICSState { > > static inline bool ics_valid_irq(ICSState *ics, uint32_t nr) > { > - return (nr >= ics->offset) > + return (ics->offset != 0) && (nr >= ics->offset) > && (nr < (ics->offset + ics->nr_irqs)); > } > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature