On 09/21/2016 09:35 AM, Daniel P. Berrange wrote: >> But I'm not sure if that suffices to meet GPL's requirements. > > The compiler.h file has no license header, just a comment > saying "public domain", which is obviously not the case > if you add this macro.
Oh, I missed that; I was assuming compiler.h was GPLv2+ per the usual project defaults; but that file is explicitly looser. > > Given that you'll need to explicitly mention the license terms > for ignore_value. eg with a comment line like > > /* The ignore_value() macro is taken from GNULIB ignore-value.h, > * licensed under the terms of the LGPLv2+ > */ Yes, adding that solves any questions of origin. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Description: OpenPGP digital signature