On 21/09/2016 13:26, Michal Privoznik wrote: > v2 of: > > http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg04710.html > > The checkpatch.pl shows the following error for 1/2: > > ERROR: architecture specific defines should be avoided > #63: FILE: util/oslib-posix.c:441: > +#if defined(__FreeBSD__) > > But I guess we should ignore the error, since in this case we > want OS specific code.
Yeah, this should probably be degraded to WARN. > diff to v1: > - Reworked 1/2 to follow Paolo's review suggestions > - Produce "(<unknown process>)" instead of "()" in 2/2 in case > the PID is unknown. > > Michal Privoznik (2): > util: Introduce qemu_get_pid_name > qemu_kill_report: Report PID name too > > include/qemu/osdep.h | 10 ++++++++++ > util/oslib-posix.c | 37 +++++++++++++++++++++++++++++++++++++ > util/oslib-win32.c | 7 +++++++ > vl.c | 8 ++++++-- > 4 files changed, 60 insertions(+), 2 deletions(-) > Looks good, thanks. Paolo