On Wed, 21 Sep 2016 15:00:21 -0500 Eric Blake <ebl...@redhat.com> wrote:
> On 09/21/2016 02:42 PM, Thomas Huth wrote: > > Basic idea of this script is to check the git log for URLs > > to the QEMU bugtracker at launchpad.net and to figure out > > whether the related bug has been marked there as "Fix released" > > (i.e. closed) already. So this script can e.g. be used after > > each public release of QEMU to check whether there are any > > bug tickets that could be moved from "Fix committed" (or another > > state if the author of the patch forgot to update the bug ticket) > > to "Fix released". > > > > Signed-off-by: Thomas Huth <th...@redhat.com> > > --- > > v3: Adressed Eric's review comments from v2 (fixed bashisms, more > > POSIX compliance, use lower-case variable names, etc.) > > > > > + > > +if [ "x$start" = "x" ]; then > > + start=`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 2 | head -n 1` > > +fi > > +if [ "x$end" = "x" ]; then > > + end=`git tag -l 'v[0-9]*\.[0-9]*.0' | tail -n 1` > > This would match v1.100 (not that we are likely to have that tag); both > lines are missing a \ before the second '.' if you are trying to > constrain it to just vX.Y.Z forms. Oh, you're right, of course - the idea was to constrain the output to the official .0 releases. > > +fi > > + > > +if [ "x$start" = "x" ] || [ "x$end" = "x" ]; then > > + echo "Could not determine start or end revision ... Please note that > > this" > > + echo "script must be run from a checked out git repository of QEMU!" > > I'd drop the ending !; we don't need to shout at the user. > > At any rate, you have indeed addressed the portability issues I pointed > out, so with the missing \ fixed, I'm okay with adding: > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks! Thomas
pgpLmVQ3C0gZR.pgp
Description: OpenPGP digital signature
