On Thu, Sep 22, 2016 at 12:10:17AM +0400, Marc-André Lureau wrote: > The 'old' dispatch code returned a QERR_MISSING_PARAMETER for missing > parameters, but the qapi qmp_dispatch() code uses > QERR_INVALID_PARAMETER_TYPE. > > Improve qapi code to return QERR_INVALID_PARAMETER_TYPE where > appropriate.
Surely this is meant to say 'return QERR_MISSING_PARAMETER', as QERR_INVALID_PARAMETER_TYPE is what its already returning. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > --- > qapi/qmp-input-visitor.c | 73 > +++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 56 insertions(+), 17 deletions(-) There's a pretty detailed unit test for this visitor, which should be further extended to cover this new behaviour. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
