On Thu, Sep 22, 2016 at 01:55:38PM +0800, Peter Xu wrote: > On Thu, Sep 22, 2016 at 03:24:43PM +1000, David Gibson wrote: > > On Wed, Sep 21, 2016 at 12:58:56PM +0800, Peter Xu wrote: > > > Intel vIOMMU is still lacking of a complete IOMMU notifier mechanism. > > > Before that is achieved, let's open a door for vhost DMAR support, which > > > only requires cache invalidations (UNMAP operations). > > > > > > Meanwhile, converting hw_error() to error_report() and exit(1), to make > > > the error messages clean and obvious (so no CPU registers will be > > > dumped). > > > > > > Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> > > > > Uh.. I didn't send an R-b for this. In fact I explicitly said I > > didn't think it should be applied until notifications have actually > > been implemented by the intel viommu. I still think that, and think > > this should just be dropped. > > Please refer to: > > https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg03034.html > > So this line is there since v5. > > I took it an honor (and also with my thankfulness) to have added your > r-b line here. I assume what you meant before was: the patch content > is okay, but you would suggest to drop this patch in this series, and > merge this until we got a real implementations for the notifiers. IMHO > that does not mean "remove your r-b in this patch". If you meant to > remove this line (I think not?), please confirm and I can remove it.
Fair enough. Sorry for my crabbiness. > I posted patch 3 just to make sure everything is coherent, and let > Paolo decide which way to choose (since I still think it's okay > actually... but again both are ok to me). Also it'll be easier for > Jason to track this down as well (so when Jason sees that Paolo > dropped patch 3, he'll naturally pick it up). If you still insist on > dropping this patch, I'll do it in v7. > > Thanks. > > -- peterx > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Description: PGP signature