On 09/23/2016 09:32 AM, Kevin Wolf wrote: > The option whether or not to use a native AIO interface really isn't a > generic option for all drivers, but only applies to the native file > protocols. This patch moves the option in blockdev-add to the > appropriate places (raw-posix and raw-win32). > > We still have to keep the flag BDRV_O_NATIVE_AIO for compatibility > because so far the AIO option was usually specified on the wrong layer > (the top-level format driver, which didn't even look at it) and then > inherited by the protocol driver (where it was actually used). We can't > forbid this use except in new interfaces. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/raw-posix.c | 44 ++++++++++++++++++++++++--------------- > block/raw-win32.c | 56 > +++++++++++++++++++++++++++++++++++++++++++++----- > qapi/block-core.json | 6 +++--- > tests/qemu-iotests/087 | 4 ++-- > 4 files changed, 83 insertions(+), 27 deletions(-) >
> +++ b/qapi/block-core.json > @@ -1724,11 +1724,13 @@ > # Driver specific block device options for the file backend. > # > # @filename: path to the image file > +# @aio: #optional AIO backend (default: threads) Missed this last time, but probably worth a '(since 2.8)' marker. Trivial enough that you can squash in during the pull request, so: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
