On 09/23/2016 12:31 AM, Paolo Bonzini wrote:
+    unsigned tb_flush_req = (unsigned) (uintptr_t) data;

Extra cast?

-    tcg_ctx.tb_ctx.tb_flush_count++;
+    atomic_inc(&tcg_ctx.tb_ctx.tb_flush_count);

Since this is the only place this value is incremented, and we're under a lock, it should be cheaper to use

  atomic_mb_set(&tcg_ctx.tb_ctx.tb_flush_count, tb_flush_req + 1);

+        uintptr_t tb_flush_req = (uintptr_t)
+            atomic_read(&tcg_ctx.tb_ctx.tb_flush_count);

Extra cast?

That said, it's correct as-is so,

Reviewed-by: Richard Henderson <r...@twiddle.net>


r~

Reply via email to