On 26/09/2016 13:10, Igor Mammedov wrote: > On Thu, 22 Sep 2016 18:16:47 +0200 > Paolo Bonzini <pbonz...@redhat.com> wrote: > >> On 22/09/2016 18:00, Igor Mammedov wrote: >>>> Why not just return initial_apic_id? This is the meaning the property >>>> had before your patch. >>> >>> initial_apic_id is immutable but 'id' could be changed at runtime by guest >>> in xAPIC mode >>> so returned value depends on xAPIC/x2APIC mode >> >> Understood, but this is just a possibly poorly-named property. "id" >> (e.g. from info qtree as opposed to info lapic) used to be the initial >> APIC ID always, even in x2APIC mode. > > 'info qtree' doesn't show CPUs anymore (since ICC bus has been removed), > but if it were it would show effective APIC ID. Same applie[ds] for > reading property value with qom-get.
Oh, thanks for correcting me then. >> Not a big deal, but thought I'd mention it since you can keep using >> static properties. > > changing initial APIC ID from guest probably wouldn't work anyway > and beak somewhere else, so we could just continue to ignore > it and use static properties for now if you prefer. No big deal---I'll let other reviewers chime in. Paolo
