Hi, On (Wed) 21 Sep 2016 [14:17:48], Sascha Silbe wrote: > Add support for the virtio 1.0 "emergency write" > (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest > debugging and might be used in cases where the guest crashes so badly > that it cannot use virtqueues. > > Disabled for compatibility machines to avoid exposing a new feature to > existing guests. > > Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> > Signed-off-by: Sascha Silbe <si...@linux.vnet.ibm.com>
This looks fine, but can you split the patch - adding find_first_connected_console(), set_config, and then finally enabling the emergency_write feature? Thanks, Amit