2016-09-23 17:17+0800, Peter Xu:
> On Thu, Sep 22, 2016 at 11:04:28PM +0200, Radim Krčmář wrote:
>> Every configuration has only up to one APIC class and we'll be extending
>> the class with a function that can be called without an instanced
>> object, so a direct access to the class is convenient.
>>
>> Signed-off-by: Radim Krčmář <rkrc...@redhat.com>
>> ---
>> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
>> @@ -306,6 +314,12 @@ static void apic_common_realize(DeviceState *dev, Error
>> **errp)
>> info = APIC_COMMON_GET_CLASS(s);
>> info->realize(dev, errp);
>>
>> + if (apic_class && apic_class != info) {
>> + error_report("All APICs must be of the same class.");
>> + exit(1);
>> + }
>
> Can user trigger this error? If not, I'd prefer:
Shouldn't be able to.
> assert(!apic_class || apic_class == info);
I'll use that, thanks.
