On Wed, Sep 28, 2016 at 11:59:19AM +0200, Paolo Bonzini wrote:
[...]
> > @@ -87,6 +87,10 @@ An IRQ is generated when written to the interrupt raise
> > register. The value
> > appears in interrupt status register when the interrupt is raised and has
> > to
> > be written to the interrupt acknowledge register to lower it.
> >
> > +The device supports both pin and MSI interrupt. By default, pin-based
> > +interrupt is used. Even if we are with MSI interrupt, we still need to
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
> Even if the driver is disabling INTx and only using MSI, it still needs
> to...
Will fix.
[...]
> > @@ -341,6 +351,7 @@ static void pci_edu_realize(PCIDevice *pdev, Error
> > **errp)
> > edu, QEMU_THREAD_JOINABLE);
> >
> > pci_config_set_interrupt_pin(pci_conf, 1);
> > + msi_init(pdev, 0, 1, false, false, errp);
>
> msi_init(pdev, 0, 1, false, false, &local_err);
> if (local_err) {
> error_propagate(errp, local_err);
> return;
> }
Could I ask why we need the local_err?
>
> But you probably want to enable 64-bit MSI too (changing the first
> "false" to "true").
Exactly. :)
>
> Otherwise looks great!
Thanks for reviewing!
-- peterx
