On 09/27/2016 10:31 PM, Nikunj A Dadhania wrote: > + tcg_gen_andi_i64(tmp1, cpu_gpr[rA(ctx->opcode)], 0xFFFFFFFF); > + tcg_gen_deposit_i64(cpu_vsrl(xT(ctx->opcode)), tmp1, tmp1, 32, 32); > + tcg_gen_mov_i64(cpu_vsrh(xT(ctx->opcode)), cpu_vsrl(xT(ctx->opcode)));
The andi is not necessary; the deposit handles all masking. Otherwise, Reviewed-by: Richard Henderson <r...@twiddle.net> r~
